Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix tidb can point update data even if tidb_super_read_only is on (#32547) #32551

Merged
merged 7 commits into from
Feb 23, 2022
Merged

planner: fix tidb can point update data even if tidb_super_read_only is on (#32547) #32551

merged 7 commits into from
Feb 23, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Feb 23, 2022 •
edited
Loading

cherry-pick #32547 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/32551

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/32551:release-5.3-221801b5525c

What problem does this PR solve?

Issue Number: close #32539

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ichn-hu @ti-srebot
cherry pick pingcap#32547 to release-5.3
d675a01 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 23, 2022
@ti-srebot ti-srebot mentioned this pull request Feb 23, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.3-cherry-pick labels Feb 23, 2022
@ti-srebot
Copy link
Contributor Author

@ichn-hu you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 23, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 23, 2022
@ichn-hu
Copy link
Contributor

ichn-hu commented Feb 23, 2022

/run-check-dev

@ichn-hu
Copy link
Contributor

ichn-hu commented Feb 23, 2022

/approve

@ichn-hu
Copy link
Contributor

ichn-hu commented Feb 23, 2022

/run-check_dev

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 23, 2022
@ichn-hu
Copy link
Contributor

ichn-hu commented Feb 23, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d675a01

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2022
@ichn-hu
Copy link
Contributor

ichn-hu commented Feb 23, 2022

/run-check_dev

@ichn-hu
Copy link
Contributor

ichn-hu commented Feb 23, 2022

the unstable test is fixed in #30716 on master but not cherry picked

@ichn-hu
Copy link
Contributor

ichn-hu commented Feb 23, 2022

/run-check_dev

@ichn-hu
Copy link
Contributor

ichn-hu commented Feb 23, 2022

/merge

@ichn-hu
Copy link
Contributor

ichn-hu commented Feb 23, 2022

/merge

@purelind
Copy link
Contributor

/run-mysql-test

@ichn-hu
Copy link
Contributor

ichn-hu commented Feb 23, 2022

/run-check_dev

@ichn-hu
Copy link
Contributor

ichn-hu commented Feb 23, 2022

/merge

@purelind
Copy link
Contributor

/run-check-dev

@purelind
Copy link
Contributor

/run-check_dev

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ichn-hu
Copy link
Contributor

ichn-hu commented Feb 23, 2022

/run-check_dev

@ichn-hu
Copy link
Contributor

ichn-hu commented Feb 23, 2022

/merge

@guo-shaoge
Copy link
Collaborator

/run-check_dev

@ti-chi-bot ti-chi-bot merged commit 5d6aa4e into pingcap:release-5.3 Feb 23, 2022
@purelind purelind added this to the v5.3.1 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees

@ichn-hu ichn-hu

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.3-cherry-pick
Projects
None yet
Milestone
v5.3.1
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @ichn-hu @purelind @guo-shaoge @wshwsh12 @VelocityLight